BurnAndRedeemFractionsFacet Code Style Findings

BAR-01C: Generic Typographic Mistake

Type	Severity	Location
Code Style		BurnAndRedeemFractionsFacet.sol:L19

Description:

The referenced line contains a typographical mistake (i.e. private variable without an underscore prefix) or generic documentational error (i.e. copy-paste) that should be corrected.

Example:

Copy
19event doReceiveAfterBuybackExecuted(uint256 indexed campaignId, address indexed account, uint256 amountOfFractions);

Recommendation:

We advise this to be done so to enhance the legibility of the codebase.

Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):

The event declaration was capitalized properly rendering it to be considered addressed.

BAR-02C: Redundant Named Function Argument

Type	Severity	Location
Gas Optimization		BurnAndRedeemFractionsFacet.sol:L21

Description:

The BurnAndRedeemFractionsFacet::initDoReceiveFacet function will redundantly use an explicit name for its input argument even though it remains unused.

Example:

Copy
21function initDoReceiveAfterBuybackFacet(bytes calldata initDoReceiveAfterBuybackData) external onlyExternalDelegateCall {}

Recommendation:

We advise the explicit name to be removed, ensuring the function still adheres to the desired function selector yet does not waste extraneous gas.

Alleviation (71cda4ccfdcfa25fb96a4565f1f8143b350dd246):

The redundantly named argument has been removed as advised, optimizing the code's syntax as well as gas cost.