Omniscia vfat Audit

Code Style

Code Style

During the manual portion of the audit, we identified 30 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ANI-01CInefficient Emission of Zero Address
ANO-01CLoop Iterator Optimizations
CRY-01CInefficient Duplicate Storage Read
FSY-01CSuboptimal Struct Declaration Styles
FSG-01CIllegible Selector Extraction
FSG-02CInexecutable Code
FSG-03CRedundant Zero-Value Assignments
FSG-04CRepetitive Value Literal
LMR-01CGeneric Typographic Mistakes
LSA-01CGeneric Typographic Mistakes
LSS-01CGeneric Typographic Mistakes
MSY-01CGeneric Typographic Mistake
MFS-01CLoop Iterator Optimizations
NFS-01CSuboptimal Struct Declaration Styles
NSL-01CSuboptimal Struct Declaration Styles
NSR-01CSuboptimal Struct Declaration Styles
NGC-01CRedundant Code Duplication
NRC-01CRedundant Code Duplication
NVC-01CRedundant Increment of Deadline
PSR-01CSignificantly Inefficient Multi-Position Adjustment
RGC-01CRedundant Code Duplication
RRC-01CRedundant Code Duplication
RVC-01CRedundant Increment of Deadlines
SMG-01CInefficient Evaluation of Atomic Signer Operation
SMG-02CInefficient Layout of Storage
SNC-01CRedundant Increment of Deadline
UVR-01CCode Redundancy
UVR-02CRedundant Increment of Deadlines
VCR-01CRedundant Increment of Deadlines
VGR-01CInexistent Combination of Conditionals

Prev

Manual Review

Next

AccessControlModule.sol (ACM-S)