Omniscia vfat Audit

MasterchefWithReferrerConnector Static Analysis Findings

MasterchefWithReferrerConnector Static Analysis Findings

MWR-01S: Multiple Top-Level Declarations

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

contracts/connectors/MasterchefWithReferrerConnector.sol
13struct MasterchefExtraData {
14 address referrer;
15}
16
17contract MasterchefWithReferrerConnector is MasterchefConnector {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.