Omniscia vfat Audit
FarmStrategy Code Style Findings
FarmStrategy Code Style Findings
FSY-01C: Suboptimal Struct Declaration Styles
| Type | Severity | Location |
|---|---|---|
| Code Style |  | FarmStrategy.sol: • I-1: L353 • I-2: L371-L375 • I-3: L402 |
Description:
The linked declaration styles of the referenced structs are using index-based argument initialization.
Example:
contracts/strategies/FarmStrategy.sol
353PositionKey(sickle, farm.stakingContract, farm.poolIndex)Recommendation:
We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The key-value declaration style has been applied across all three referenced instances, addressing this exhibit.