SimpleLendingStrategy Static Analysis Findings

SLS-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		SimpleLendingStrategy.sol:L18-L29

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
18constructor(
19    SickleFactory factory,
20    ConnectorRegistry connectorRegistry,
21    FlashloanStrategy flashloanStrategy,
22    TransferLib transferLib_
23)
24    StrategyModule(factory, connectorRegistry)
25    FlashloanInitiator(flashloanStrategy)
26{
27    transferLib = transferLib_;
28    strategyAddress = address(this);
29}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.