AggregatorConnector Static Analysis Findings

ACR-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		AggregatorConnector.sol:L22-L26

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
22constructor(
23    address router_
24) {
25    router = router_;
26}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.

ACR-02S: Multiple Top-Level Declarations

Type	Severity	Location
Code Style		AggregatorConnector.sol:L12, L16

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

Copy
12struct AggregatorExtraData {
13    bytes data;
14}
15
16contract AggregatorConnector is ILiquidityConnector {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.