Omniscia vfat Audit
NftFarmStrategy Code Style Findings
NftFarmStrategy Code Style Findings
NFS-01C: Suboptimal Struct Declaration Styles
| Type | Severity | Location |
|---|---|---|
| Code Style |  | NftFarmStrategy.sol: • I-1: L139 • I-2: L275 • I-3: L511 • I-4: L532 • I-5: L560 • I-6: L577 • I-7: L728 |
Description:
The linked declaration styles of the referenced structs are using index-based argument initialization.
Example:
contracts/strategies/NftFarmStrategy.sol
139NftPosition(params.farm, params.nft, tokenId),Recommendation:
We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The key-value declaration style has been applied across all seven referenced instances, addressing this exhibit.