Omniscia vfat Audit
RamsesV3Connector Code Style Findings
RamsesV3Connector Code Style Findings
RVC-01C: Redundant Increment of Deadlines
Type | Severity | Location |
---|---|---|
Gas Optimization | ![]() | RamsesV3Connector.sol: • I-1: L40 • I-2: L87 |
Description:
The deadline parameter of a Ramses swap or NFT position manager interaction can be the block.timestamp
itself.
Example:
contracts/connectors/ramses/RamsesV3Connector.sol
36ISwapRouter.ExactInputParams memory params = ISwapRouter37 .ExactInputParams({38 path: extraData.path,39 recipient: address(this),40 deadline: block.timestamp + 1,41 amountIn: swap.amountIn,42 amountOutMinimum: swap.minAmountOut43});
Recommendation:
We advise this to be set so, omitting the addition by one in each instance and thus optimizing the code's gas cost.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The redundant deadline increments highlighted have been omitted as advised.