Omniscia vfat Audit
ComptrollerConnector Static Analysis Findings
ComptrollerConnector Static Analysis Findings
CCR-01S: Multiple Top-Level Declarations
Type | Severity | Location |
---|---|---|
Code Style | ![]() | ComptrollerConnector.sol:L10, L14 |
Description:
The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.
Example:
contracts/connectors/ComptrollerConnector.sol
10struct ComptrollerExtraData {11 address[] cTokens;12}13
14contract ComptrollerConnector is IFarmConnector {
Recommendation:
We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.