AerodromeGaugeRegistry Static Analysis Findings

AGR-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		AerodromeGaugeRegistry.sol:L20-L32

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
20constructor(
21    IGaugeRegistryVoter voter_,
22    IPoolFactory v2PairFactory_,
23    IPoolFactory slipstreamPairFactory_,
24    AerodromeGaugeConnector v2GaugeConnector_,
25    SlipstreamGaugeConnector slipstreamGaugeConnector_
26) {
27    voter = voter_;
28    v2PairFactory = v2PairFactory_;
29    slipstreamPairFactory = slipstreamPairFactory_;
30    v2GaugeConnector = v2GaugeConnector_;
31    slipstreamGaugeConnector = slipstreamGaugeConnector_;
32}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.