Omniscia vfat Audit
ConnectorRegistry Static Analysis Findings
ConnectorRegistry Static Analysis Findings
CRY-01S: Multiple Top-Level Declarations
Type | Severity | Location |
---|---|---|
Code Style | ![]() | ConnectorRegistry.sol:L9, L13 |
Description:
The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.
Example:
contracts/ConnectorRegistry.sol
9interface ICustomConnectorRegistry {10 function connectorOf(address target) external view returns (address);11}12
13contract ConnectorRegistry is Admin, TimelockAdmin {
Recommendation:
We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.