Omniscia vfat Audit
SwapLib Manual Review Findings
SwapLib Manual Review Findings
SLB-01M: Potential Token Incompatibility
| Type | Severity | Location |
|---|---|---|
| Standard Conformity |  | SwapLib.sol:L58 |
Description:
Certain non-standard tokens will disallow an allowance of 0 to be configured as an optimization, such as the Ethereum main-net BNB variant.
Impact:
The severity of this exhibit will be adjusted depending on whether the SwapLib is expected to be compatible with tokens such as BNB or not.
Example:
contracts/libraries/SwapLib.sol
58SafeTransferLib.safeApprove(tokenIn, swapParams.router, 0);Recommendation:
We advise the code to either accommodate for such non-standard tokens or to note that they are not supported explicitly, either of which we consider an adequate alleviation of this exhibit.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The vfat team evaluated this exhibit and clarified that they are aware of this issue and intend to acknowledge that certain non-standard tokens will not work with their system.