GaugeRegistry Static Analysis Findings

GRY-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		GaugeRegistry.sol:L16-L19

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
16constructor(IGaugeRegistryVoter voter_, address connector_) {
17    voter = voter_;
18    connector = connector_;
19}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.

GRY-02S: Multiple Top-Level Declarations

Type	Severity	Location
Code Style		GaugeRegistry.sol:L6, L12

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

Copy
6interface IGaugeRegistryVoter {
7    function isGauge(address target) external view returns (bool);
8
9    function poolForGauge(address gauge) external view returns (address);
10}
11
12contract GaugeRegistry is ICustomConnectorRegistry {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.