Omniscia vfat Audit
RamsesRouterConnector Static Analysis Findings
RamsesRouterConnector Static Analysis Findings
RRC-01S: Multiple Top-Level Declarations
Type | Severity | Location |
---|---|---|
Code Style | ![]() | RamsesRouterConnector.sol:L16, L20, L24 |
Description:
The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.
Example:
contracts/connectors/ramses/RamsesRouterConnector.sol
16struct RamsesLiquidityExtraData {17 bool isStablePool;18}19
20struct RamsesSwapExtraData {
Recommendation:
We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.