ComptrollerRegistry Static Analysis Findings

CRR-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		ComptrollerRegistry.sol:L14-L20

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
14constructor(
15    ComptrollerV1Storage comptroller_,
16    CompoundMarketConnector connector_
17) {
18    comptroller = comptroller_;
19    connector = connector_;
20}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.