NftSettingsRegistry Code Style Findings

NSR-01C: Suboptimal Struct Declaration Styles

Type	Severity	Location
Code Style		NftSettingsRegistry.sol: • I-1: L186 • I-2: L195 • I-3: L241 • I-4: L423-L425 • I-5: L427 • I-6: L442-L457

Description:

The linked declaration styles of the referenced structs are using index-based argument initialization.

Example:

Copy
186NftKey memory key = NftKey(sickle, nftManager, tokenId);

Recommendation:

We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.

Alleviation (6ab7af3bb4):

The key-value declaration style has been applied solely to three out of the six struct declarations referenced by this exhibit, rendering it partially addressed.

Alleviation (986c6b0a71):

The key-value declaration style has been applied to the applicable remaining instances, addressing this exhibit in full.