Omniscia vfat Audit
UniswapV2Connector Static Analysis Findings
UniswapV2Connector Static Analysis Findings
UVC-01S: Multiple Top-Level Declarations
Type | Severity | Location |
---|---|---|
Code Style | ![]() | UniswapV2Connector.sol:L17, L21 |
Description:
The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.
Example:
contracts/connectors/UniswapV2Connector.sol
17struct UniswapV2SwapExtraData {18 address[] path;19}20
21contract UniswapV2Connector is ILiquidityConnector {
Recommendation:
We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.