NuriGaugeRegistry Static Analysis Findings

NGR-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		NuriGaugeRegistry.sol:L22-L34

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
22constructor(
23    IGaugeRegistryVoter voter_,
24    NuriGaugeConnector nuriGaugeConnector_,
25    INuriPairFactory nuriPairFactory_,
26    NuriV3Connector nuriV3Connector_,
27    address nuriCLGaugeFactory_
28) {
29    voter = voter_;
30    nuriGaugeConnector = nuriGaugeConnector_;
31    nuriPairFactory = nuriPairFactory_;
32    nuriV3Connector = nuriV3Connector_;
33    nuriCLGaugeFactory = nuriCLGaugeFactory_;
34}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.

NGR-02S: Multiple Top-Level Declarations

Type	Severity	Location
Code Style		NuriGaugeRegistry.sol:L11, L15

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

Copy
11interface INuriPairFactory {
12    function isPair(address pair) external view returns (bool);
13}
14
15contract NuriGaugeRegistry is ICustomConnectorRegistry {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.