Omniscia vfat Audit
MorphoConnector Static Analysis Findings
MorphoConnector Static Analysis Findings
MCR-01S: Multiple Top-Level Declarations
Type | Severity | Location |
---|---|---|
Code Style | ![]() | MorphoConnector.sol:L17, L23 |
Description:
The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.
Example:
contracts/connectors/MorphoConnector.sol
17struct MorphoExtraData {18 MarketParams marketParams;19 uint256 shares; // For repay20 Id id;21}22
23contract MorphoConnector is ILendingConnector {
Recommendation:
We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.
Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):
The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.