SickleMultisig Static Analysis Findings

SMG-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		SickleMultisig.sol:L366-L372

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
366function _addSigner(address signer) internal changesSettings {
367    if (isSigner(signer)) revert SignerAlreadyAdded();
368
369    _signers.add(signer);
370
371    emit SignerAdded(signer);
372}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.