RamsesRouterConnector Code Style Findings

RRC-01C: Redundant Code Duplication

Type	Severity	Location
Standard Conformity		RamsesRouterConnector.sol:L61-L73

Description:

The RamsesRouterConnector implementation is identical to the VelodromeRouterConnector with the main difference being the RamsesRouterConnector::swapExactTokensForTokens implementation that boasts a different IRamsesRouter::Route payload.

Example:

Copy
20struct RamsesSwapExtraData {
21    IRamsesRouter.Route[] routes;
22}

Recommendation:

We advise the code to inherit the VelodromeRouterConnector and to override the relevant function, reducing the codebase's overall redundancy.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated the potential restructure of the project as described in the exhibit and opted to retain a clear distinction between the Ramses contract stack and the Velodrome contract stack so as to ensure a certain level of consistency and coherency between vastly different implementations even though they might resemble each other.