LendingMigrator Static Analysis Findings

LMR-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		LendingMigrator.sol:L33-L41

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
33constructor(
34    SickleFactory factory,
35    ConnectorRegistry connectorRegistry,
36    FlashloanStrategy flashloanStrategy_,
37    FeesLib feesLib_
38) StrategyModule(factory, connectorRegistry) {
39    flashloanStrategy = flashloanStrategy_;
40    feesLib = feesLib_;
41}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.

LMR-02S: Multiple Top-Level Declarations

Type	Severity	Location
Code Style		LendingMigrator.sol:L18, L25, L29

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

Copy
18struct MigratePositionParams {
19    address sickleAddress;
20    address borrowerAddress;
21    address lendingMarket;
22    address strategy;
23}
24
25library LendingMigratorFees {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.