Omniscia vfat Audit

VelodromeRouterConnector Static Analysis Findings

VelodromeRouterConnector Static Analysis Findings

VRC-01S: Multiple Top-Level Declarations

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

contracts/connectors/velodrome/VelodromeRouterConnector.sol
15struct VelodromeLiquidityExtraData {
16 bool isStablePool;
17}
18
19struct VelodromeSwapExtraData {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.