SweepStrategy Static Analysis Findings

SSY-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		SweepStrategy.sol:L23-L30

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
23constructor(
24    SickleFactory factory,
25    NftTransferLib nftTransferLib_,
26    TransferLib transferLib_
27) StrategyModule(factory, ConnectorRegistry(address(0))) {
28    nftTransferLib = nftTransferLib_;
29    transferLib = transferLib_;
30}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.