Omniscia vfat Audit

RamsesV3Connector Static Analysis Findings

RamsesV3Connector Static Analysis Findings

RVC-01S: Multiple Top-Level Declarations

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

contracts/connectors/ramses/RamsesV3Connector.sol
22struct RamsesV3SwapExtraData {
23 address pool;
24 bytes path;
25}
26
27contract RamsesV3Connector is UniswapV3Connector {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The vfat team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.