NftSettingsLib Code Style Findings

NSL-01C: Suboptimal Struct Declaration Styles

Type	Severity	Location
Code Style		NftSettingsLib.sol: • I-1: L24 • I-2: L35

Description:

The linked declaration styles of the referenced structs are using index-based argument initialization.

Example:

Copy
24NftKey(Sickle(payable(address(this))), nftManager, tokenId);

Recommendation:

We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.

Alleviation (6ab7af3bb495b817ffec469255ea679b1813eecb):

The key-value declaration style has been applied across all two referenced instances and an additional one, addressing this exhibit.